-
Notifications
You must be signed in to change notification settings - Fork 6
Tailwinds conversions #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Replace custom pagination with Pagy bootstrap helper and ensure search filter params persist across pages - Update search ordering to use published_at instead of created_at for topics - Fix password reset page link text expected by tests (Login) and restore test description text - Adjust Searcheable concern year/month scopes to handle blank params safely
…ect and ensure correct ordering for tests
- Ensure state filter respects enums in Searcheable#by_state - Force immediate form submission for month and state selects to avoid stale content in tests
We do not have a surver/privacy policy/terms of use and only registered users can log in, so I removed those links and the card that made it sound like anyone could sign up.
With the old design, we were filtering out archived topics by default.
850fe0c to
a6811e4
Compare
|
I've resolved the conflicts/removed some unnecessary links, still need to fix:
|
This was causing the content of the table to be displayed by default on a green background, making it hard to read.
It wasn't clear to me what it meant when I saw it. Since it is not some kind of code to help idenfity a certain category of topic, I think it is best to remove it to avoid confusion and leave more space for the title.
82f5572 to
5afd19b
Compare
|
I still need to:
|
Before, no error was shown when uploading unaccepted file types, so users could create a Topic and think the files were uploaded, but they were not.
1d3dd55 to
8cbf967
Compare
I've also slightly changed the wording because: - this website is only for managing the learning resources, not for users to learn - it is not yet possible to active two-factor authentication
The choose_tag helper is no longer used so I removed it.
65481bf to
ef035af
Compare
| </footer> | ||
|
|
||
| <style> | ||
| @keyframes fade-in-up { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to load this as an asset?
|
|
||
| content_tag :nav, 'aria-label': "Page navigation" do | ||
| content_tag :ul, class: "flex -space-x-px text-sm", style: "list-style: none; margin: 0; padding: 0;" do | ||
| safe_join([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this to connect page with tailwind?
| <%= render "shared/errors", errors: language.errors.full_messages, resource_name: language.class.name %> | ||
|
|
||
| <div style="margin-bottom: 1.5rem;"> | ||
| <%= f.label :name, style: "display: block; font-size: 0.875rem; font-weight: 600; color: #374151; margin-bottom: 0.5rem;" do %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use inline styles and not classes?
|
|
||
| if ! gem list foreman -i --silent; then | ||
| echo "Installing foreman..." | ||
| gem install foreman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using overwind already, check bin/server please
| def create | ||
| @tag = Tag.new(tag_params) | ||
|
|
||
| if @tag.save |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we combine Tailwind with some tags-related task in this PR.
Is it correct?

WIP