Skip to content

Conversation

@seanmarcia
Copy link
Member

WIP

@dcollie2
Copy link
Collaborator

dcollie2 commented Oct 8, 2025

We'll want to get the tag and file management interfaces back in shape.
image

seanmarcia and others added 17 commits November 10, 2025 14:42
- Replace custom pagination with Pagy bootstrap helper and ensure search filter params persist across pages
- Update search ordering to use published_at instead of created_at for topics
- Fix password reset page link text expected by tests (Login) and restore test description text
- Adjust Searcheable concern year/month scopes to handle blank params safely
- Ensure state filter respects enums in Searcheable#by_state
- Force immediate form submission for month and state selects to avoid stale content in tests
We do not have a surver/privacy policy/terms of use and only registered
users can log in, so I removed those links and the card that made it
sound like anyone could sign up.
With the old design, we were filtering out archived topics by default.
@Oli0li Oli0li force-pushed the tailwinds_conversions branch from 850fe0c to a6811e4 Compare November 10, 2025 18:03
@Oli0li
Copy link
Collaborator

Oli0li commented Nov 10, 2025

I've resolved the conflicts/removed some unnecessary links, still need to fix:

  • pagination
  • tags
  • document upload interface
  • "Topic statistics" not aligned on Topic form
  • Background colour for rows on Region charts (hard to read until we hover on a row)
  • I think we can remove the capital letter on a purple background on the Topic list, it wasn't clear to me that this was the first letter of the Topic name, which led me to wonder if this was some kind of code

This was causing the content of the table to be displayed by default
on a green background, making it hard to read.
It wasn't clear to me what it meant when I saw it. Since it is not some
kind of code to help idenfity a certain category of topic, I think it is
best to remove it to avoid confusion and leave more space for the title.
@Oli0li Oli0li force-pushed the tailwinds_conversions branch from 82f5572 to 5afd19b Compare November 18, 2025 19:07
@Oli0li
Copy link
Collaborator

Oli0li commented Nov 28, 2025

I still need to:

  • fix the provider select on the user form
  • fix tests
  • fix vulnerability warning
  • only allow uploads of accepted file (currently, users don't see any error when upload unauthorized content types. We just don't attach the document without telling them)

Before, no error was shown when uploading unaccepted file types, so users
could create a Topic and think the files were uploaded, but they were not.
@Oli0li Oli0li force-pushed the tailwinds_conversions branch from 1d3dd55 to 8cbf967 Compare November 29, 2025 19:27
I've also slightly changed the wording because:
- this website is only for managing the learning resources, not for
users to learn
- it is not yet possible to active two-factor authentication
The choose_tag helper is no longer used so I removed it.
@Oli0li Oli0li force-pushed the tailwinds_conversions branch from 65481bf to ef035af Compare November 29, 2025 19:45
</footer>

<style>
@keyframes fade-in-up {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to load this as an asset?


content_tag :nav, 'aria-label': "Page navigation" do
content_tag :ul, class: "flex -space-x-px text-sm", style: "list-style: none; margin: 0; padding: 0;" do
safe_join([
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this to connect page with tailwind?

<%= render "shared/errors", errors: language.errors.full_messages, resource_name: language.class.name %>

<div style="margin-bottom: 1.5rem;">
<%= f.label :name, style: "display: block; font-size: 0.875rem; font-weight: 600; color: #374151; margin-bottom: 0.5rem;" do %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use inline styles and not classes?


if ! gem list foreman -i --silent; then
echo "Installing foreman..."
gem install foreman
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using overwind already, check bin/server please

def create
@tag = Tag.new(tag_params)

if @tag.save
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we combine Tailwind with some tags-related task in this PR.
Is it correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants